Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable contact info (Jetpack block) in prod after fixing contact info focus issues. #3340

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Enable contact info (Jetpack block) in prod after fixing contact info focus issues. #3340

merged 2 commits into from
Apr 15, 2021
+2 −2

Conversation

illusaen
Copy link
Contributor

@illusaen illusaen commented Apr 6, 2021 •
edited
Loading

Fixes bug where selecting and typing in an inner block on Contact Info and then exiting out of the block fast (clicking on a different unnested block) would cause cursor to stay in the original inner block and thus result in an unhideable keyboard.

Jetpack repo: #19367

Test:

  • Have Jetpack-enabled site with version > 8.5.
  • Create new post
  • Add contact info block
  • Type 'test' into "Address Line 2"
  • Quickly click on "Email"
  • See that cursor is removed from "Address Line 2" and keyboard hides.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@illusaen illusaen requested a review from cameronvoell April 6, 2021 20:16
@illusaen illusaen mentioned this pull request Apr 6, 2021
Merged
cameronvoell
cameronvoell approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Automattic/jetpack#19367

This PR Will be ready to merge once Automattic/jetpack#19367 is merged to master, and this PR has its reference updated to jetpack master branch. 🙇

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@illusaen illusaen merged commit b48739b into develop Apr 15, 2021
@illusaen illusaen deleted the fix-contact-info-focus branch April 15, 2021 20:34
@dcalhoun dcalhoun mentioned this pull request Apr 16, 2021
Merged
3 tasks
@illusaen illusaen changed the title Jetpack hash for fixing contact info focus issues. Enable contact info (Jetpack block) in prod after fixing contact info focus issues. Apr 16, 2021
@thehenrybyrd thehenrybyrd mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illusaen @cameronvoell